-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Nakedcard): new component #819
Conversation
Size stats
|
Accessibility report ℹ️ You can run this locally by executing |
Deploy preview for mistica-web ready! ✅ Preview Built with commit 533571b. |
Screenshot tests report ✔️ All passing |
...t_tests__/__image_snapshots__/naked-card-screenshot-test-tsx-naked-card-closeable-1-snap.png
Outdated
Show resolved
Hide resolved
|
||
return ( | ||
<CardContainer | ||
width={width} | ||
height={height} | ||
dataAttributes={{...dataAttributes, 'component-name': 'PosterCard'}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can use getPrefixedDataAttributes
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, that's already done inside CardContainer
src/card.tsx
Outdated
<div style={{position: 'relative'}}> | ||
{isTouchable && ( | ||
<div | ||
className={classNames(styles.touchableMediaOverlay, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The media part of the naked differs from the media hover definition, and uses the same overlay that displayMedia and poster cards with the following tokens:
coverBackgroundHover
, coverBackgroundPressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, looks much better now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# [14.18.0](v14.17.1...v14.18.0) (2023-07-20) ### Bug Fixes * **DisplayMediaCard, PosterCard:** add label to video control ([#823](#823)) ([dc765ef](dc765ef)) * **row:** add missing dataAttributes ([#815](#815)) ([47e7cab](47e7cab)) ### Features * **AdvancedDataCard:** new community component ([#780](#780)) ([2803b9c](2803b9c)) * **Blocks:** new Mistica Community Components ([#770](#770)) ([8fc368a](8fc368a)) * **Header:** small version, allow removing vertical padding ([#822](#822)) ([448387e](448387e)) * **Nakedcard:** new component ([#819](#819)) ([688bb8e](688bb8e))
🎉 This PR is included in version 14.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.